[CodeCompletion] Add keypath apply subscript after open bracket #31980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Windows |
rintaro
commented
May 22, 2020
lib/IDE/ExprContextAnalysis.cpp
Outdated
|
|
||
| // Add 'subscript<T>(keyPath: KeyPath<Root, T>) -> T'. | ||
| if (name.getBaseName() == DeclBaseName::createSubscript() && | ||
| (baseTy->getAnyNominal() || baseTy->is<ArchetypeType>())) { |
There was a problem hiding this comment.
Hm, I didn't know this works:
func foo(val: (String, Int)) {
_ = val[keyPath: \.0]
}This limitation is not needed.
There was a problem hiding this comment.
As for meta type types, the only possible keypath is \.self (e.g. String.self[keyPath: \.self]) because keypath cannot refer static members. @benlangmuir Do you think limiting this to non-metatype types here makes sense?
There was a problem hiding this comment.
I ended up with just adding || baseTy->is<TupleType>() here.
There was a problem hiding this comment.
I have no strong opinion. Seems fine to me either way.
rdar://problem/61016147
rintaro
force-pushed
the
ide-completion-keypathsubscript-rdar61016147
branch
from
5fb4f13 to
38d8b13
Compare
|
@swift-ci Please smoke test |
benlangmuir
approved these changes
Jun 9, 2020
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should suggest
keyPath:argument.Add
(keyPath: KeyPath<BaseType, T>) -> Ttype in the callee analysis for subscript expressions.rdar://problem/61016147